Add ENV variable to skip network test #2264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
requested review from
Kay-Zee,
bjartek,
chasefleming,
jribbink,
mfbz and
nvdtf
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
We could also just remove them in favour of a local emulator? It was probably a mistake on my end to use networking in the first place for the fork tests. |
jribbink
approved these changes
Jan 29, 2026
Contributor
Author
|
IMO they are useful, but they should perhaps be in more of an integration test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making a nix derivation for flow-cli I noticed that some tests use networking. This fails in sandboxed environments. I added a
SKIP_NETWORK_TESTSenv variable to optionally skip them.For contributor use:
masterbranchFiles changedin the Github PR explorer